Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: chrome/browser/browser_process_impl.cc

Issue 42233: Add unit tests for DevToolsManager (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browser_process_impl.h" 5 #include "chrome/browser/browser_process_impl.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/thread.h" 9 #include "base/thread.h"
10 #include "base/waitable_event.h" 10 #include "base/waitable_event.h"
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 void BrowserProcessImpl::CreateDebuggerWrapper(int port) { 356 void BrowserProcessImpl::CreateDebuggerWrapper(int port) {
357 DCHECK(debugger_wrapper_.get() == NULL); 357 DCHECK(debugger_wrapper_.get() == NULL);
358 created_debugger_wrapper_ = true; 358 created_debugger_wrapper_ = true;
359 359
360 debugger_wrapper_ = new DebuggerWrapper(port); 360 debugger_wrapper_ = new DebuggerWrapper(port);
361 } 361 }
362 362
363 void BrowserProcessImpl::CreateDevToolsManager() { 363 void BrowserProcessImpl::CreateDevToolsManager() {
364 DCHECK(!devtools_manager_.get()); 364 DCHECK(!devtools_manager_.get());
365 created_devtools_manager_ = true; 365 created_devtools_manager_ = true;
366 devtools_manager_.reset(new DevToolsManager()); 366 devtools_manager_.reset(new DevToolsManager(
367 NULL /*Create DevToolsWindows directly*/));
367 } 368 }
368 369
369 void BrowserProcessImpl::CreateAcceleratorHandler() { 370 void BrowserProcessImpl::CreateAcceleratorHandler() {
370 #if defined(OS_WIN) 371 #if defined(OS_WIN)
371 DCHECK(accelerator_handler_.get() == NULL); 372 DCHECK(accelerator_handler_.get() == NULL);
372 scoped_ptr<views::AcceleratorHandler> accelerator_handler( 373 scoped_ptr<views::AcceleratorHandler> accelerator_handler(
373 new views::AcceleratorHandler); 374 new views::AcceleratorHandler);
374 accelerator_handler_.swap(accelerator_handler); 375 accelerator_handler_.swap(accelerator_handler);
375 #else 376 #else
376 // TODO(port): remove this completely, it has no business being here. 377 // TODO(port): remove this completely, it has no business being here.
377 #endif 378 #endif
378 } 379 }
379 380
380 void BrowserProcessImpl::CreateGoogleURLTracker() { 381 void BrowserProcessImpl::CreateGoogleURLTracker() {
381 DCHECK(google_url_tracker_.get() == NULL); 382 DCHECK(google_url_tracker_.get() == NULL);
382 scoped_ptr<GoogleURLTracker> google_url_tracker(new GoogleURLTracker); 383 scoped_ptr<GoogleURLTracker> google_url_tracker(new GoogleURLTracker);
383 google_url_tracker_.swap(google_url_tracker); 384 google_url_tracker_.swap(google_url_tracker);
384 } 385 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/debugger/devtools_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698