Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Issue 4223001: Add pyauto tests and helper files for system-level testing of Web SQL Databases. (Closed)

Created:
10 years, 1 month ago by kkania
Modified:
9 years, 7 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, John Grabowski, anantha, Nirnimesh, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add pyauto tests and helper files for system-level testing of Web SQL Databases. BUG=59379 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64746

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : Actually reload the page, instead of renavigating #

Total comments: 15

Patch Set 4 : Fix comments #

Patch Set 5 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -33 lines) Patch
A chrome/test/data/database/database_tester.html View 1 chunk +161 lines, -0 lines 0 comments Download
A chrome/test/functional/databases.py View 1 2 3 4 1 chunk +253 lines, -0 lines 0 comments Download
M chrome/test/functional/notifications.py View 1 2 3 4 7 chunks +7 lines, -33 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kkania
10 years, 1 month ago (2010-10-29 18:04:03 UTC) #1
Nirnimesh
Is it possible to have a pyauto hook which can dump all info about all ...
10 years, 1 month ago (2010-11-01 06:37:29 UTC) #2
kkania
http://codereview.chromium.org/4223001/diff/4001/5002 File chrome/test/functional/databases.py (right): http://codereview.chromium.org/4223001/diff/4001/5002#newcode24 chrome/test/functional/databases.py:24: self.GetFileURLForDataPath('web_database/database_tester.html')) On 2010/11/01 06:37:29, Nirnimesh wrote: > '/' will ...
10 years, 1 month ago (2010-11-01 18:50:23 UTC) #3
Nirnimesh
10 years, 1 month ago (2010-11-01 18:56:38 UTC) #4
LGTM

http://codereview.chromium.org/4223001/diff/4001/5002
File chrome/test/functional/databases.py (right):

http://codereview.chromium.org/4223001/diff/4001/5002#newcode24
chrome/test/functional/databases.py:24:
self.GetFileURLForDataPath('web_database/database_tester.html'))
On 2010/11/01 18:50:23, kkania wrote:
> On 2010/11/01 06:37:29, Nirnimesh wrote:
> > '/' will not work on win
> 
> I did the same thing for notifications.py. Do I need to change that too?  I
can
> open a file on python windows using /. What's the reason this won't work?

Yes, please fix that too
While python recognizes / and converts to \ behind the scenes, it's still better
to use os.path.join() instead. Ex: if you invoke a shell command using this
path, it'll fail

Powered by Google App Engine
This is Rietveld 408576698