Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Side by Side Diff: base/lock_impl_posix.cc

Issue 42225: Change some DCHECK( == 0), to DCHECK_EQ in the posix lock implementation. (Closed)
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/lock_impl.h" 5 #include "base/lock_impl.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 10
11 LockImpl::LockImpl() { 11 LockImpl::LockImpl() {
12 #ifndef NDEBUG 12 #ifndef NDEBUG
13 // In debug, setup attributes for lock error checking. 13 // In debug, setup attributes for lock error checking.
14 pthread_mutexattr_t mta; 14 pthread_mutexattr_t mta;
15 int rv = pthread_mutexattr_init(&mta); 15 int rv = pthread_mutexattr_init(&mta);
16 DCHECK(rv == 0); 16 DCHECK_EQ(rv, 0);
17 rv = pthread_mutexattr_settype(&mta, PTHREAD_MUTEX_ERRORCHECK); 17 rv = pthread_mutexattr_settype(&mta, PTHREAD_MUTEX_ERRORCHECK);
18 DCHECK(rv == 0); 18 DCHECK_EQ(rv, 0);
19 rv = pthread_mutex_init(&os_lock_, &mta); 19 rv = pthread_mutex_init(&os_lock_, &mta);
20 DCHECK(rv == 0); 20 DCHECK_EQ(rv, 0);
21 rv = pthread_mutexattr_destroy(&mta); 21 rv = pthread_mutexattr_destroy(&mta);
22 DCHECK(rv == 0); 22 DCHECK_EQ(rv, 0);
23 #else 23 #else
24 // In release, go with the default lock attributes. 24 // In release, go with the default lock attributes.
25 pthread_mutex_init(&os_lock_, NULL); 25 pthread_mutex_init(&os_lock_, NULL);
26 #endif 26 #endif
27 } 27 }
28 28
29 LockImpl::~LockImpl() { 29 LockImpl::~LockImpl() {
30 int rv = pthread_mutex_destroy(&os_lock_); 30 int rv = pthread_mutex_destroy(&os_lock_);
31 DCHECK(rv == 0); 31 DCHECK_EQ(rv, 0);
32 } 32 }
33 33
34 bool LockImpl::Try() { 34 bool LockImpl::Try() {
35 int rv = pthread_mutex_trylock(&os_lock_); 35 int rv = pthread_mutex_trylock(&os_lock_);
36 DCHECK(rv == 0 || rv == EBUSY); 36 DCHECK(rv == 0 || rv == EBUSY);
37 return rv == 0; 37 return rv == 0;
38 } 38 }
39 39
40 void LockImpl::Lock() { 40 void LockImpl::Lock() {
41 int rv = pthread_mutex_lock(&os_lock_); 41 int rv = pthread_mutex_lock(&os_lock_);
42 DCHECK(rv == 0); 42 DCHECK_EQ(rv, 0);
43 } 43 }
44 44
45 void LockImpl::Unlock() { 45 void LockImpl::Unlock() {
46 int rv = pthread_mutex_unlock(&os_lock_); 46 int rv = pthread_mutex_unlock(&os_lock_);
47 DCHECK(rv == 0); 47 DCHECK_EQ(rv, 0);
48 } 48 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698