Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: net/base/ssl_config_service_win.cc

Issue 4222005: Turn on file access checks on Win. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Second try Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_version_info.cc ('k') | net/proxy/proxy_config_service_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/ssl_config_service_win.cc
===================================================================
--- net/base/ssl_config_service_win.cc (revision 64981)
+++ net/base/ssl_config_service_win.cc (working copy)
@@ -4,6 +4,7 @@
#include "net/base/ssl_config_service_win.h"
+#include "base/thread_restrictions.h"
#include "base/win/registry.h"
using base::TimeDelta;
@@ -59,6 +60,9 @@
// static
bool SSLConfigServiceWin::GetSSLConfigNow(SSLConfig* config) {
+ // This registry access goes to disk and will slow down the IO thread.
+ // http://crbug.com/61455
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
RegKey internet_settings;
if (!internet_settings.Open(HKEY_CURRENT_USER, kInternetSettingsSubKeyName,
KEY_READ))
@@ -83,6 +87,8 @@
// static
void SSLConfigServiceWin::SetRevCheckingEnabled(bool enabled) {
+ // This registry access goes to disk and will slow down the IO thread.
+ // http://crbug.com/61455
DWORD value = enabled;
RegKey internet_settings(HKEY_CURRENT_USER, kInternetSettingsSubKeyName,
KEY_WRITE);
@@ -108,6 +114,8 @@
// static
void SSLConfigServiceWin::SetSSLVersionEnabled(int version, bool enabled) {
+ // This registry access goes to disk and will slow down the IO thread.
+ // http://crbug.com/61455
RegKey internet_settings(HKEY_CURRENT_USER, kInternetSettingsSubKeyName,
KEY_READ | KEY_WRITE);
DWORD value;
« no previous file with comments | « chrome/common/chrome_version_info.cc ('k') | net/proxy/proxy_config_service_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698