Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 4222005: Turn on file access checks on Win. (Closed)

Created:
10 years, 1 month ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, evanm
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 4

Patch Set 8 : '' #

Patch Set 9 : Second try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -30 lines) Patch
M base/base.gypi View 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M base/file_util_win.cc View 2 3 4 5 6 7 8 41 chunks +70 lines, -0 lines 0 comments Download
M base/file_version_info_win.cc View 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M base/platform_file_win.cc View 2 3 4 5 6 7 8 7 chunks +10 lines, -0 lines 0 comments Download
M base/win/registry.cc View 2 3 4 5 6 7 8 22 chunks +24 lines, -0 lines 0 comments Download
M base/win_util.cc View 6 7 8 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/browser.cc View 6 7 8 1 chunk +13 lines, -7 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/shared_resources_data_source.cc View 6 7 8 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/download/download_util.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/download/save_package.cc View 7 8 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.cc View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 6 7 8 2 chunks +11 lines, -16 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/chrome_version_info.cc View 3 4 5 6 7 8 2 chunks +3 lines, -0 lines 0 comments Download
M net/base/ssl_config_service_win.cc View 3 4 5 6 7 8 4 chunks +8 lines, -0 lines 0 comments Download
M net/proxy/proxy_config_service_win.cc View 3 4 5 6 7 8 3 chunks +8 lines, -0 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 6 7 8 2 chunks +8 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_url_request_info.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
10 years, 1 month ago (2010-11-03 19:31:48 UTC) #1
evanm
Awesome! LGTM http://codereview.chromium.org/4222005/diff/76001/77008 File chrome/browser/browser_main.cc (right): http://codereview.chromium.org/4222005/diff/76001/77008#newcode486 chrome/browser/browser_main.cc:486: #if (defined(OS_LINUX) && !defined(OS_CHROMEOS)) || defined(OS_MACOSX) || ...
10 years, 1 month ago (2010-11-03 19:38:07 UTC) #2
jam
10 years, 1 month ago (2010-11-03 19:55:33 UTC) #3 
all done, will wait for green run

Powered by Google App Engine
This is Rietveld 408576698