Issue 4218006: Add rietveld member to ChangeInfo and use this value to contact rietveld.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4218006: Add rietveld member to ChangeInfo and use this value to contact rietveld. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, M-A Ruel, jochen (gone - plz use gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add rietveld member to ChangeInfo and use this value to contact rietveld. This makes gcl to use a specific rietveld instance per change list. This is useful when moving from one rietveld instance to another, so in-flight reviews are sent to the right instance. Also clear gcl.CODEREVIEW_SETTINGS between gcl_unittest tests to remove tests interference. TEST=updated unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64631

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -89 lines)			Patch
	M	gcl.py	View		14 chunks	+62 lines, -65 lines	0 comments	Download
	M	tests/gcl_unittest.py	View		13 chunks	+34 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Forwarding to John since I think Jochen left for the day.

10 years, 1 month ago (2010-11-01 17:15:28 UTC) #2

lgtm

Expand Messages | Collapse Messages