Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 42173: Added automatic debug break for processing debugger commands (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

A new stack guard break flag DEBUGCOMMAND has been introduced. This is used to signal debug break due to debugger commands available in the queue for processing. If a stack guard break happens with this flag and not the DEBUGBREAK flag the no debug break event is generated and execution is resumed automatically when all debugger commands in the queue has been processed. This makes it possible to remote debuggers to just add commands to the queue without having to request a break as well. As soon as any JavaScript executes the debugger commands will be processed and the response send to the remote debugger. Currently hide this behind a flag (--debugger-auto-break) as the current command line debugger in Chrome is not designed for this new behaviour, whereas the new Chrome developer tools will use it. Committed: http://code.google.com/p/v8/source/detail?r=1508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -47 lines) Patch
M src/debug.h View 4 chunks +15 lines, -3 lines 0 comments Download
M src/debug.cc View 12 chunks +42 lines, -17 lines 0 comments Download
M src/execution.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/execution.cc View 4 chunks +30 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 7 chunks +19 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-13 13:07:17 UTC) #1
Mads Ager (chromium)
11 years, 9 months ago (2009-03-13 13:14:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698