Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 4216001: Initial support for built-in DNS resolver/cache. (Closed)

Created:
10 years, 1 month ago by agayev
Modified:
9 years, 7 months ago
Reviewers:
cbentzel, eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, amit, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Initial support for built-in DNS resolver/cache. BUG=60149 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64271

Patch Set 1 #

Patch Set 2 : add raw_host_resolver_proc.* #

Patch Set 3 : add missing files #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -20 lines) Patch
M chrome/browser/io_thread.cc View 1 2 chunks +18 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/common/net/raw_host_resolver_proc.h View 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/common/net/raw_host_resolver_proc.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/service/net/service_url_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/test_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/mediator_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_resolver.h View 2 chunks +7 lines, -6 lines 0 comments Download
M net/base/host_resolver_impl.cc View 2 chunks +2 lines, -1 line 1 comment Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/tcp_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/fetch/fetch_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
agayev
Same thing that got reverted, doing one more round of trybots before committing.
10 years, 1 month ago (2010-10-28 15:23:40 UTC) #1
eroman
9 years, 11 months ago (2011-01-10 20:13:45 UTC) #2
http://codereview.chromium.org/4216001/diff/6001/net/base/host_resolver_impl.cc
File net/base/host_resolver_impl.cc (right):

http://codereview.chromium.org/4216001/diff/6001/net/base/host_resolver_impl....
net/base/host_resolver_impl.cc:75: HostResolverProc* resolver_proc,
This change doesn't make sense to me.

The "CreateSystemHostResolver()" is supposed to be creating a host resolver that
uses the underlying system's getaddrinfo().

However if we pass in a custom HostResolverProc then that is not the case.

I don't think we should be adding an extra parameter to this function which will
always be NULL. Rather the one location(s) which want to create their custom
non-system host resolver should just call:

   new HostResolverImpl(resolver_proc, ....)

In fact for the feature you ware working on I think it should be implemented as
a separate HostResolver subclass alltogether, and not use a custom
HostResolverProc.

(The HostResolverProc were really just a feature for unit-tests, in order to
mock out the system dependency).

Powered by Google App Engine
This is Rietveld 408576698