Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 4215006: Make dumpRSAPublicKey also accept a public key in PEM format (Closed)

Created:
10 years, 1 month ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Make dumpRSAPublicKey also accept a public key in PEM format This change makes dumpRSAPublicKey directly accept a public key in PEM format. This makes it possible to avoid the unnecessary step of generating a self-signed certificate to dump the public key in .keyb format. The old style certificate input is still accepted. Using certs (as done previously): dumpRSAPublicKey -cert <certfile> Directly using public keys: dumpRSAPublicKey -pub <pubfile> Change-Id: Ic35b59aff6613d145d7947212650da281f734b74 BUG=7576 TEST=manual $ openssl genrsa -F4 -out test.pem 4096 $ openssl rsa -in test.pem -out test.pub $ dumpRSAPublicKey -pub test.pub >test.pub.keyb Verify that this matches the output we get using the old style <cert> input. $ openssl req -batch -new -x509 -key test.pem -out test.cert $ dumpRSAPublicKey -cert test.cert >test.cert.keyb $ diff test.pub.keyb test.cert.keyb $ Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=551037b

Patch Set 1 #

Patch Set 2 : remove spurious key add #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M tests/devkeys/create_new_keys.sh View 1 chunk +1 line, -1 line 0 comments Download
M tests/gen_test_keys.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M utility/dev_make_keypair View 1 chunk +1 line, -1 line 0 comments Download
M utility/dumpRSAPublicKey.c View 1 chunk +30 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
10 years, 1 month ago (2010-10-29 20:56:43 UTC) #1
Randall Spangler
10 years, 1 month ago (2010-11-01 15:54:49 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698