Issue 42147: Increase fudge factor to let WatchdogTest.AlarmTest pass reliably on slower m...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42147: Increase fudge factor to let WatchdogTest.AlarmTest pass reliably on slower m... (Closed)

Created:
11 years, 9 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Increase fudge factor to let WatchdogTest.AlarmTest pass reliably on slower machine under valgrind

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	base/watchdog.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

dank

Hey Dean, you're looking at Valgrind stuff, and worked on watchdog; does this look safe? ...

11 years, 9 months ago (2009-03-12 21:15:10 UTC) #1

Dean McNamee

I'm not familiar enough with this to say ok. You should talk to Erik Kay ...

11 years, 9 months ago (2009-03-13 13:43:35 UTC) #2

Dean McNamee

Er, and you'd have to talk to Jar and Pawel about the implementation of watchdog.

11 years, 9 months ago (2009-03-13 13:44:21 UTC) #3

dank

Hi Erik, Dean says you were looking at timeout problems under purify. This change gets ...

11 years, 9 months ago (2009-03-16 14:22:06 UTC) #4

Giving up for now, suppressing that test under valgrind.