Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 4214004: Merge 70748 - 2010-10-27 Andy Estes <aestes@apple.com>... (Closed)

Created:
10 years, 1 month ago by jamesr
Modified:
9 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 70748 - 2010-10-27 Andy Estes <aestes@apple.com>; Reviewed by Adam Barth. r66156 broke AtlasCT library, formerly affected http://map.d.co.il/ https://bugs.webkit.org/show_bug.cgi?id=45679 This patch removes WebKit's map of classid values to MIME types. It also changes the behavior of object elements to render fallback content when a non-empty classid attribute is specified, which is the behavior HTML5 specifies when a UA encounters a classid it doesn't understand. Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html * html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. (WebCore::HTMLObjectElement::updateWidget): Do not call serviceTypeForClassId() when there is no type attribute, and render fallback content if the classid attribute is non-empty. 2010-10-27 Andy Estes <aestes@apple.com>; Reviewed by Adam Barth. r66156 broke AtlasCT library, formerly affected http://map.d.co.il/ https://bugs.webkit.org/show_bug.cgi?id=45679 * fast/dom/object-embed-plugin-scripting.html: Changed classid attributes to type attributes. * fast/dom/object-plugin-hides-properties.html: Ditto. * fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt: Added. * fast/replaced/object-with-non-empty-classid-triggers-fallback.html: Added. TBR=cpu@google.com BUG=57986 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -33 lines) Patch
M LayoutTests/fast/dom/object-embed-plugin-scripting.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/object-plugin-hides-properties.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/replaced/object-with-non-empty-classid-triggers-fallback.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/html/HTMLObjectElement.cpp View 3 chunks +6 lines, -32 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
10 years, 1 month ago (2010-10-29 18:48:19 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698