Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: src/codegen-ia32.cc

Issue 42138: Fix a test in the IA32 code generator for whether loop conditions... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-ia32.cc
===================================================================
--- src/codegen-ia32.cc (revision 1503)
+++ src/codegen-ia32.cc (working copy)
@@ -2231,7 +2231,8 @@
// Do not duplicate conditions with function literal
// subexpressions. This can cause us to compile the function
// literal twice.
- bool test_at_bottom = !node->has_function_literal();
+ bool test_at_bottom =
+ !scope_->is_global_scope() && !node->has_function_literal();
IncrementLoopNesting();
@@ -2329,7 +2330,8 @@
// Do not duplicate conditions with function literal
// subexpressions. This can cause us to compile the function
// literal twice.
- bool test_at_bottom = !node->has_function_literal();
+ bool test_at_bottom =
+ !scope_->is_global_scope() && !node->has_function_literal();
// Compile the init expression if present.
if (node->init() != NULL) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698