Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 42127: Reenable the duplicated test at the bottom of for and while loops. It... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Reenable the duplicated test at the bottom of for and while loops. It is enabled for a loop by the absence of function literal subexpressions in the condition expression. Committed: http://code.google.com/p/v8/source/detail?r=1503

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M src/ast.h View 3 chunks +11 lines, -2 lines 2 comments Download
M src/codegen-ia32.cc View 4 chunks +28 lines, -13 lines 0 comments Download
M src/jump-target.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/rewriter.cc View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
11 years, 9 months ago (2009-03-12 15:37:53 UTC) #1
Kasper Lund
LGTM. It's a good thing that loops aren't expressions. http://codereview.chromium.org/42127/diff/1/2 File src/ast.h (right): http://codereview.chromium.org/42127/diff/1/2#newcode331 Line ...
11 years, 9 months ago (2009-03-12 15:40:30 UTC) #2
Kevin Millikin (Chromium)
11 years, 9 months ago (2009-03-12 15:42:44 UTC) #3
http://codereview.chromium.org/42127/diff/1/2
File src/ast.h (right):

http://codereview.chromium.org/42127/diff/1/2#newcode331
Line 331: bool has_function_literal_;
On 2009/03/12 15:40:30, Kasper Lund wrote:
> Maybe add a comment here that this is a function literal in the condition?

Done.

Powered by Google App Engine
This is Rietveld 408576698