src/top.h - Issue 42117: Revert the exception propagation fix. It leads to crashes because...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/top.h

Issue 42117: Revert the exception propagation fix. It leads to crashes because... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/top.h

===================================================================

--- src/top.h (revision 1495)

+++ src/top.h (working copy)

@@ -158,12 +158,10 @@

}

static void setup_external_caught() {

- if (!thread_local_.external_caught_exception_) {

- thread_local_.external_caught_exception_ =

- has_pending_exception() &&

- (thread_local_.catcher_ != NULL) &&

- (thread_local_.try_catch_handler_ == thread_local_.catcher_);

- }

+ thread_local_.external_caught_exception_ =

+ (!thread_local_.pending_exception_->IsTheHole()) &&

+ (thread_local_.catcher_ != NULL) &&

+ (Top::thread_local_.try_catch_handler_ == Top::thread_local_.catcher_);

}

// Tells whether the current context has experienced an out of memory

« no previous file with comments | « no previous file | src/top.cc » ('j') | no next file with comments »