Issue 42117: Revert the exception propagation fix. It leads to crashes because...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42117: Revert the exception propagation fix. It leads to crashes because... (Closed)

Created:
11 years, 9 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Revert the exception propagation fix. It leads to crashes because Top::external_caught_exception_ and Top::try_catch_handler_ are no longer in sync. Pulling it out until I have the time to fix it. Committed: http://code.google.com/p/v8/source/detail?r=1497

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -58 lines)			Patch
M	src/top.h	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	src/top.cc	View	1 chunk	+9 lines, -29 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	test/cctest/test-api.cc	View	5 chunks	+4 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Unfortunately this LGTM.

Expand Messages | Collapse Messages