Issue 421006: Fix recognizing FTP listings consisting of only one line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 421006: Fix recognizing FTP listings consisting of only one line. (Closed)

Created:
11 years, 1 month ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
eroman, wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix recognizing FTP listings consisting of only one line. It turns out we have to be a little more strict with that. Before this change both ls and VMS listing parsers would claim that they recognize the format. Also fallback to Mozilla code was broken in that case. TEST=Covered by net_unittests. BUG=28263

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -1 line)			Patch
A	net/data/ftp/dir-listing-ls-5	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	net/data/ftp/dir-listing-ls-5.expected	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_buffer.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_buffer.cc	View	2 chunks	+30 lines, -1 line	0 comments	Download
M	net/ftp/ftp_directory_listing_buffer_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parsers.h	View	4 chunks	+7 lines, -0 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parsers.cc	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parsers_unittest.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

11 years, 1 month ago (2009-11-23 19:38:47 UTC) #4

LGTM.

I only skimmed through the non-test files.  It's unfortunate
that OnEndOfInput() returns int in one class but returns bool
in another class.  But that's not a big deal.

In the future if eroman reviews your changeslists, you can
check them in without waiting for my reviews.  Thanks.

Expand Messages | Collapse Messages