Issue 421005: Make executeScript and insertCSS inject code into all frames....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 421005: Make executeScript and insertCSS inject code into all frames.... (Closed)

Created:
11 years, 1 month ago by tangjie1

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make executeScript and insertCSS inject code into all frames. Patched from 401007(see http://codereview.chromium.org/401007/) to commit. Reviewed by aa and darin. R=aa,darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32634

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -41 lines)			Patch
M	chrome/browser/extensions/execute_code_in_tab_function.h	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/execute_code_in_tab_function.cc	View	1	4 chunks	+17 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/execute_script_apitest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module_constants.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1	4 chunks	+14 lines, -4 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1	4 chunks	+39 lines, -15 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/executescript/test.html	View	1	3 chunks	+19 lines, -4 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/executescript_in_frame/frame0.html	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/executescript_in_frame/frame1.html	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/executescript_in_frame/frame2.html	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/executescript_in_frame/frame3.html	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/executescript_in_frame/manifest.json	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/executescript_in_frame/script.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/executescript_in_frame/test.html	View		1 chunk	+68 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/executescript_in_frame/test_executescript.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download