Issue 4210: Parse /proc/self/maps lines better to handle variations between Linux kernels...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4210: Parse /proc/self/maps lines better to handle variations between Linux kernels... (Closed)

Created:
12 years, 3 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
bak

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Parse /proc/self/maps lines better to handle variations between Linux kernels. It seems noone has had time to file a bug on this. Committed: http://code.google.com/p/v8/source/detail?r=360

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	src/platform-linux.cc	View		2 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bak

12 years, 3 months ago (2008-09-23 08:51:17 UTC) #2

Hi Eric

Your fix should help profiling on various Linux platforms.
However, we might want to use sscan for reading the proc information.

LGTM,
  Lars

Expand Messages | Collapse Messages