Issue 42087: SkiaFontWin.cpp: close the SkPath after each polygon rather than only once. L...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42087: SkiaFontWin.cpp: close the SkPath after each polygon rather than only once. L... (Closed)

Created:
11 years, 9 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
brettw, agl, dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

SkiaFontWin.cpp: close the SkPath after each polygon rather than only once. Letters like 'A' and 'D', which have multiple polygons, were missing pieces when being stroked. This was discovered while investigating LayoutTests/svg/custom/struct-use-09-b.svg but it is only a partial fix for that test. There is also some offset between the stroke and fill. upstreamed: https://bugs.webkit.org/show_bug.cgi?id=24526

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/WebKit/WebCore/platform/graphics/skia/SkiaFontWin.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

I'll upstream it as well, but I want to commit it locally so I can ...

11 years, 9 months ago (2009-03-11 22:27:02 UTC) #4

Ok. Please do it soon.

Expand Messages | Collapse Messages