Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issue 42083: Avoid leaks at shutdown when running purify... (Closed)

Created:
11 years, 9 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Avoid leaks at shutdown when running purify We'll risk a (rare) crash under purify, but avoid having a leak detected. Note that this "leak" at shutdown is NBD, but this code at least shows that the would be leak is "understood" and acceptable. bug=6532 r=erikkay Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11473

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M base/message_loop.cc View 1 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jar (doing other things)
11 years, 9 months ago (2009-03-11 19:13:36 UTC) #1
Erik does not do reviews
LGTM
11 years, 9 months ago (2009-03-11 19:39:43 UTC) #2
darin (slow to review)
11 years, 9 months ago (2009-03-12 00:04:31 UTC) #3
this change means that we can also remove a lot of RunAllPending calls that we
have been accumulating.  is someone going to take that on?

Powered by Google App Engine
This is Rietveld 408576698