Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 4208002: Revert 64202 - Initial support for built-in DNS resolver/cache.... (Closed)

Created:
10 years, 1 month ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
agayev
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, amit, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org
Visibility:
Public.

Description

Revert 64202 - Initial support for built-in DNS resolver/cache. BUG=None TEST=None Review URL: http://codereview.chromium.org/3693001 TBR=agayev@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -109 lines) Patch
M chrome/browser/io_thread.cc View 2 chunks +1 line, -18 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/net/raw_host_resolver_proc.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/common/net/raw_host_resolver_proc.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/service/net/service_url_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/test_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/mediator_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_resolver.h View 2 chunks +6 lines, -7 lines 0 comments Download
M net/base/host_resolver_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
MM net/socket/tcp_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/fetch/fetch_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Yusuke Sato
10 years, 1 month ago (2010-10-28 04:59:08 UTC) #1
cbentzel
10 years, 1 month ago (2010-10-28 11:21:03 UTC) #2
Was this reverted due to the unit_tests failures on Mac 10.6 Tests (dbg)(3)?

That looks like an unrelated testserver.py start up problem. I suppose
Abutalib can reland today.

On Thu, Oct 28, 2010 at 12:59 AM, <yusukes@chromium.org> wrote:

> Reviewers: agayev,
>
> Description:
> Revert 64202 - Initial support for built-in DNS resolver/cache.
>
> BUG=None
> TEST=None
>
> Review URL: http://codereview.chromium.org/3693001
>
> TBR=agayev@chromium.org
>
> Please review this at http://codereview.chromium.org/4208002/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/io_thread.cc
>  M     chrome/chrome_common.gypi
>  D     chrome/common/net/raw_host_resolver_proc.h
>  D     chrome/common/net/raw_host_resolver_proc.cc
>  M     chrome/service/net/service_url_request_context.cc
>  M     chrome/test/plugin/plugin_test.cpp
>  M     chrome_frame/metrics_service.cc
>  M     chrome_frame/test/test_server_test.cc
>  M     jingle/notifier/listener/mediator_thread_impl.cc
>  M     net/base/host_resolver.h
>  M     net/base/host_resolver_impl.cc
>  M     net/proxy/proxy_script_fetcher_impl_unittest.cc
>  MM    net/socket/tcp_client_socket_unittest.cc
>  M     net/test/test_server.cc
>  M     net/tools/fetch/fetch_client.cc
>  M     net/url_request/url_request_unittest.h
>  M     webkit/tools/test_shell/test_shell_request_context.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698