Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 4206002: Firefox import broken for first run on Mac (Closed)

Created:
10 years, 1 month ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

If default browser is set to FF, and Chrome is run as first-run with an empty profile, import ignores FF data and imports from Safari instead. BUG=61112 TEST=see bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64298

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M chrome/browser/cocoa/search_engine_dialog_controller.h View 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/search_engine_dialog_controller.mm View 2 3 4 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/importer/importer_list.cc View 2 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Miranda Callahan
10 years, 1 month ago (2010-10-28 18:21:12 UTC) #1
Avi (use Gerrit)
10 years, 1 month ago (2010-10-28 18:30:21 UTC) #2
LGTM; put a description in the CL.

Powered by Google App Engine
This is Rietveld 408576698