Issue 42044: Adding fixed guids to some modules to facilitate incremental switch to gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42044: Adding fixed guids to some modules to facilitate incremental switch to gyp. (Closed)

Created:
11 years, 9 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Adding fixed guids to some modules to facilitate incremental switch to gyp. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11388

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -0 lines)			Patch
M	base/base.gyp	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	breakpad/breakpad.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	build/temp_gyp/googleurl.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	build/temp_gyp/v8.gyp	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	google_update/google_update.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/media.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/net.gyp	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	printing/printing.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	sandbox/sandbox.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdch/sdch.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	skia/skia.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	testing/gtest.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/bzip2/bzip2.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/libjpeg/libjpeg.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/libpng/libpng.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/libxml/libxml.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/libxslt/libxslt.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/modp_b64/modp_b64.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/sqlite/sqlite.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/zlib/zlib.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/activex_shim/activex_shim.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/activex_shim_dll/activex_shim_dll.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/default_plugin/default_plugin.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 9 months ago (2009-03-10 22:08:24 UTC) #2

I'd prefer the GUIDs not inside {braces} since that's more of a specific
formatting thing you can add in the generator, but this LGTM.

Expand Messages | Collapse Messages