Issue 4203001: cashew: libcurl http fetcher: use default CA certificate path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4203001: cashew: libcurl http fetcher: use default CA certificate path (Closed)

Created:
10 years, 1 month ago by Vince Laviano

Modified:
9 years ago

Reviewers:
Jason Glasgow

CC:
chromium-os-reviews_chromium.org, Vince Laviano, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/cashew.git

Visibility:
Public.

Description

cashew: libcurl http fetcher: use default CA certificate path Modify LibcurlHttpFetcher to use the default CA certificate path instead of a custom path Cherrypick change introducing LibcurlHttpFetcher::GetHttpResponseCode method from update_engine, and augment it with better error logging when curl_easy_getinfo call fails. Tweak Service::OnUsageUrlUpdate to make it easier to override the incoming url. BUG=chromium-os:8225 TEST=Manual testing. Overrode url to be an https url and performed requests against https-enabled test server. Observed results in logs. Change-Id: I7a106cb62385b48fdfc6b49c6042a3c29f92ac9d Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=aa59d8a

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -17 lines)			Patch
M	src/libcurl_http_fetcher.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/libcurl_http_fetcher.cc	View	6 chunks	+22 lines, -15 lines	0 comments	Download
M	src/service.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vince Laviano

cc'ing adlr because this relates to (temporarily) forked LibcurlHttpFetcher code.

10 years, 1 month ago (2010-10-27 01:13:25 UTC) #1

LGTM

Expand Messages | Collapse Messages