Issue 42029: Checking in media::FFmpegGlue, media::FFmpegDemuxer and tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42029: Checking in media::FFmpegGlue, media::FFmpegDemuxer and tests. (Closed)

Created:
11 years, 9 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Checking in media::FFmpegGlue, media::FFmpegDemuxer and tests. Fixes build break by including FFmpeg dependency for media project in chrome.sln. This is a second attempt at committing the following changelists: http://codereview.chromium.org/39295 http://codereview.chromium.org/28165 TBR=darin

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1445 lines, -11 lines)			Patch
M	chrome/chrome.sln	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	media/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/base/mock_media_filters.h	View	7 chunks	+29 lines, -6 lines	0 comments	Download
M	media/base/pipeline.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	media/build/media.vcproj	View	3 chunks	+26 lines, -2 lines	0 comments	Download
M	media/build/media_unittests.vcproj	View	3 chunks	+10 lines, -2 lines	0 comments	Download
A	media/filters/ffmpeg_common.h	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	media/filters/ffmpeg_common.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	media/filters/ffmpeg_demuxer.h	View	1 chunk	+127 lines, -0 lines	0 comments	Download
A	media/filters/ffmpeg_demuxer.cc	View	1 chunk	+281 lines, -0 lines	0 comments	Download
A	media/filters/ffmpeg_demuxer_unittest.cc	View	1 chunk	+360 lines, -0 lines	0 comments	Download
A	media/filters/ffmpeg_glue.h	View	1 chunk	+80 lines, -0 lines	0 comments	Download
A	media/filters/ffmpeg_glue.cc	View	1 chunk	+162 lines, -0 lines	0 comments	Download
A	media/filters/ffmpeg_glue_unittest.cc	View	1 chunk	+309 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

11 years, 9 months ago (2009-03-10 18:54:38 UTC) #1

Contains build fix in chrome.sln.

Rest of the patch is the same as reviewed by erikkay.

Expand Messages | Collapse Messages