base/string_util_icu.cc - Issue 42011: Normalize end of file newlines in base/. All files end in a single newline.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/string_util_icu.cc

Issue 42011: Normalize end of file newlines in base/. All files end in a single newline. (Closed)

Patch Set: Revert changed to third_party. Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/string_tokenizer_unittest.cc ('k') | base/string_util_posix.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/string_util.h"	5 #include "base/string_util.h"

6	6

7 #include <string.h>	7 #include <string.h>

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/basictypes.h"	10 #include "base/basictypes.h"

(...skipping 525 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
536 // This implementation is not so fast since it converts the text encoding	536 // This implementation is not so fast since it converts the text encoding

537 // twice. Please feel free to file a bug if this function hurts the	537 // twice. Please feel free to file a bug if this function hurts the

538 // performance of Chrome.	538 // performance of Chrome.

539 DCHECK(IsStringUTF8(input));	539 DCHECK(IsStringUTF8(input));

540 std::wstring input_wide = UTF8ToWide(input);	540 std::wstring input_wide = UTF8ToWide(input);

541 std::wstring output_wide;	541 std::wstring output_wide;

542 TrimPositions result = TrimWhitespace(input_wide, positions, &output_wide);	542 TrimPositions result = TrimWhitespace(input_wide, positions, &output_wide);

543 *output = WideToUTF8(output_wide);	543 *output = WideToUTF8(output_wide);

544 return result;	544 return result;

545 }	545 }

546

OLD	NEW