base/condition_variable_win.cc - Issue 42011: Normalize end of file newlines in base/. All files end in a single newline.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/condition_variable_win.cc

Issue 42011: Normalize end of file newlines in base/. All files end in a single newline. (Closed)

Patch Set: Revert changed to third_party. Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/condition_variable_unittest.cc ('k') | base/debug_message.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/condition_variable.h"	5 #include "base/condition_variable.h"

6	6

7 #include <stack>	7 #include <stack>

8	8

9 #include "base/lock.h"	9 #include "base/lock.h"

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 425 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
436 waiting_list. A hash table (STL map) could be used, but I was embarrased to	436 waiting_list. A hash table (STL map) could be used, but I was embarrased to

437 use a complex and relatively low efficiency container when a doubly linked list	437 use a complex and relatively low efficiency container when a doubly linked list

438 provided O(1) performance in all required operations. Since other operations	438 provided O(1) performance in all required operations. Since other operations

439 to provide performance-and/or-fairness required queue (FIFO) and list (LIFO)	439 to provide performance-and/or-fairness required queue (FIFO) and list (LIFO)

440 containers, I would also have needed to use an STL list/queue as well as an STL	440 containers, I would also have needed to use an STL list/queue as well as an STL

441 map. In the end I decided it would be "fun" to just do it right, and I	441 map. In the end I decided it would be "fun" to just do it right, and I

442 put so many assertions (DCHECKs) into the container class that it is trivial to	442 put so many assertions (DCHECKs) into the container class that it is trivial to

443 code review and validate its correctness.	443 code review and validate its correctness.

444	444

445 */	445 */

446

OLD	NEW