Making what gets generated platform conditional to allow gradual phase in on ...

Making what gets generated platform conditional to allow gradual phase in on windows.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11387

[Mark Mentovai, 2009-03-10 04:23:02]

http://codereview.chromium.org/42003/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/42003/diff/1/2#newcode20
Line 20: ['OS!="win"', {
I'd actually like to see this gated on a variable so that people who want to
give the whole thing a spin (like yourself) can use something like "gyp -S_test
-Dall_gyps=1".  To handle that, we'd do (just typing here, please verify this
works properly...)

'variables': {
  'conditions': [
    ['OS!="win"', {
      'all_gyps%': 1,
    }, {  # else: OS=="win"
      'all_gyps%': 0,
    }],
  ],
}

Then you can make this condition test 'all_gyps==1'

Or something along those lines, anyway...

It's gonna be temporary, but we can at least make it awesome while we've got it,
right?

[bradn, 2009-03-10 22:07:31]

ping

http://codereview.chromium.org/42003/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/42003/diff/1/2#newcode20
Line 20: ['OS!="win"', {
On 2009/03/10 04:23:02, Mark Mentovai wrote:
> I'd actually like to see this gated on a variable so that people who want to
> give the whole thing a spin (like yourself) can use something like "gyp
-S_test
> -Dall_gyps=1".  To handle that, we'd do (just typing here, please verify this
> works properly...)
> 
> 'variables': {
>   'conditions': [
>     ['OS!="win"', {
>       'all_gyps%': 1,
>     }, {  # else: OS=="win"
>       'all_gyps%': 0,
>     }],
>   ],
> }
> 
> Then you can make this condition test 'all_gyps==1'
> 
> Or something along those lines, anyway...
> 
> It's gonna be temporary, but we can at least make it awesome while we've got
it,
> right?

Done.

[Mark Mentovai, 2009-03-10 22:13:16]

Sorry, missed the earlier e-mail.  LGTM.