Remove old bookmark sync promo from new tab page....

Remove old bookmark sync promo from new tab page.

BUG=28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32754

[Miranda Callahan, 2009-11-20 18:18:21]

Hmm, I should at least remove the js with promo message in it; coming shortly.

On 2009/11/20 18:15:50, Miranda Callahan wrote:
>

[Miranda Callahan, 2009-11-20 18:19:59]

On second glance -- I don't think the js needs to be touched. It's all used for
status messages as well as the promo message.

[Miranda Callahan, 2009-11-20 22:24:01]

Hi, Idan -- please take another look; I removed the PROMOTION enum, and
references to it.  I am not sure about the JS code; I don't see anything that
specifically refers to the promo message (it all seems to be built for the
general passing and display of status messages), and I'd rather do dead code
removing that doesn't relate directly to the removal of this promo in a separate
bug, to minimize the possibility of things breaking...

[idana, 2009-11-20 22:57:00]

LGTM

I am fine with landing the code the way it is. However, it looks like both the
JS code and the NNTP handler can be cleaned up a bit and it'd be nice to open a
bug so that we can track this. For example, the msgtype 'presynced' is never
used but it is being set by the handler and is documented in the JS file. Also,
the JS file documents using the 'synced' msgtype, but it is not actually used in
practice.

Also, if you are planning to merge this change into the stable branch (which I
think you are), you have to make sure you don't merge the .grd file from this
CL.