Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: chrome/browser/chromeos/cros/cros_mock.cc

Issue 4200008: Revert 64191 - Add 3G Activation to the network menu.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/status/network_menu.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/cros_mock.cc
===================================================================
--- chrome/browser/chromeos/cros/cros_mock.cc (revision 64192)
+++ chrome/browser/chromeos/cros/cros_mock.cc (working copy)
@@ -275,7 +275,7 @@
// NetworkDropdownButton::NetworkChanged() calls:
EXPECT_CALL(*mock_network_library_, ethernet_connected())
- .Times(1)
+ .Times(2) // also called by NetworkMenu::InitMenuItems()
.WillRepeatedly((Return(false)))
.RetiresOnSaturation();
EXPECT_CALL(*mock_network_library_, wifi_connected())
@@ -295,7 +295,7 @@
.WillRepeatedly((Return(false)))
.RetiresOnSaturation();
EXPECT_CALL(*mock_network_library_, Connected())
- .Times(1)
+ .Times(2) // also called by NetworkMenu::InitMenuItems()
.WillRepeatedly((Return(false)))
.RetiresOnSaturation();
EXPECT_CALL(*mock_network_library_, Connecting())
@@ -304,22 +304,30 @@
.RetiresOnSaturation();
// NetworkMenu::InitMenuItems() calls:
- EXPECT_CALL(*mock_network_library_, ethernet_available())
+ EXPECT_CALL(*mock_network_library_, ethernet_connecting())
.Times(1)
- .WillRepeatedly((Return(true)))
- .RetiresOnSaturation();
- EXPECT_CALL(*mock_network_library_, ethernet_connected())
- .Times(1)
.WillRepeatedly((Return(false)))
.RetiresOnSaturation();
- EXPECT_CALL(*mock_network_library_, ethernet_connecting())
+ EXPECT_CALL(*mock_network_library_, wifi_networks())
.Times(1)
- .WillRepeatedly((Return(false)))
+ .WillRepeatedly((ReturnRef(wifi_networks_)))
.RetiresOnSaturation();
EXPECT_CALL(*mock_network_library_, wifi_available())
.Times(1)
.WillRepeatedly((Return(false)))
.RetiresOnSaturation();
+ EXPECT_CALL(*mock_network_library_, wifi_network())
+ .Times(1)
+ .WillRepeatedly((ReturnRef(wifi_network_)))
+ .RetiresOnSaturation();
+ EXPECT_CALL(*mock_network_library_, cellular_networks())
+ .Times(1)
+ .WillRepeatedly((ReturnRef(cellular_networks_)))
+ .RetiresOnSaturation();
+ EXPECT_CALL(*mock_network_library_, cellular_network())
+ .Times(1)
+ .WillRepeatedly((ReturnRef(cellular_network_)))
+ .RetiresOnSaturation();
EXPECT_CALL(*mock_network_library_, cellular_available())
.Times(1)
.WillRepeatedly((Return(false)))
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/status/network_menu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698