Issue 4200005: Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4200005: Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put (Closed)

Created:
10 years, 1 month ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Part 4/4 of immutable Extension refactor: Kill Extension::StaticData and put its guts into Extension. BUG=56558 TEST=no functional change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64676

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+338 lines, -414 lines)			Patch
M	chrome/browser/extensions/extension_info_map.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_info_map.cc	View	8 chunks	+14 lines, -13 lines	0 comments	Download
M	chrome/browser/extensions/extension_info_map_unittest.cc	View	4 chunks	+25 lines, -25 lines	0 comments	Download
M	chrome/browser/profile_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension.h	View	7 chunks	+204 lines, -260 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	41 chunks	+86 lines, -108 lines	1 comment	Download
M	chrome/common/extensions/extension_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

10 years, 1 month ago (2010-10-28 00:15:09 UTC) #2

LGTM!

http://codereview.chromium.org/4200005/diff/1/7
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/4200005/diff/1/7#newcode2229
chrome/common/extensions/extension.cc:2229: // thread, but we're in common and
don't have access to BrowserThread.
I still think this is kinda wonky and should probably just be pulled out into a
separate object, but we can leave that for a separate project.

If you want to protect this for the time being, you could use the hack from
ExtensionResource -- have a static method that on Extension that sets a
ThreadID, call this from BrowserMain or whatever with the UI thread's ID.

Expand Messages | Collapse Messages