webkit/glue/plugins/plugin_lib_unittest.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/plugins/plugin_lib_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/plugins/plugin_lib_unittest.cc

diff --git a/webkit/glue/plugins/plugin_lib_unittest.cc b/webkit/glue/plugins/plugin_lib_unittest.cc

index 5ac6bdc6e6cd5aa71348f48c69b52c00364d3220..45c4bb66dfbeaeeb9bcb21c4ebea4fc885baa0db 100644

--- a/webkit/glue/plugins/plugin_lib_unittest.cc

+++ b/webkit/glue/plugins/plugin_lib_unittest.cc

@@ -25,7 +25,7 @@ TEST(PluginLibLoading, UnloadAllPlugins) {

PluginLibTest::CreatePluginLib(FilePath()));

// Try with a single plugin lib.

- scoped_refptr<PluginLibTest> plugin_lib1 = new PluginLibTest();

+ scoped_refptr<PluginLibTest> plugin_lib1(new PluginLibTest());

NPAPI::PluginLib::UnloadAllPlugins();

// Need to create it again, it should have been destroyed above.

@@ -34,7 +34,7 @@ TEST(PluginLibLoading, UnloadAllPlugins) {

// Try with two plugin libs.

plugin_lib1 = new PluginLibTest();

- scoped_refptr<PluginLibTest> plugin_lib2 = new PluginLibTest();

+ scoped_refptr<PluginLibTest> plugin_lib2(new PluginLibTest());

NPAPI::PluginLib::UnloadAllPlugins();

// Need to create it again, it should have been destroyed above.

« no previous file with comments | « webkit/glue/plugins/plugin_host.cc ('k') | webkit/glue/plugins/webplugin_delegate_impl.cc » ('j') | no next file with comments »