Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: webkit/appcache/appcache_group_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/util.cc ('k') | webkit/appcache/appcache_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_group_unittest.cc
diff --git a/webkit/appcache/appcache_group_unittest.cc b/webkit/appcache/appcache_group_unittest.cc
index 128fbc7abf97868b62e47a465c6babec03adba29..c42722c311cd78da71a9eff1094cd5d0e991c83f 100644
--- a/webkit/appcache/appcache_group_unittest.cc
+++ b/webkit/appcache/appcache_group_unittest.cc
@@ -99,39 +99,39 @@ class AppCacheGroupTest : public testing::Test {
TEST(AppCacheGroupTest, AddRemoveCache) {
MockAppCacheService service;
- scoped_refptr<AppCacheGroup> group =
- new AppCacheGroup(&service, GURL("http://foo.com"), 111);
+ scoped_refptr<AppCacheGroup> group(
+ new AppCacheGroup(&service, GURL("http://foo.com"), 111));
base::Time now = base::Time::Now();
- scoped_refptr<AppCache> cache1 = new AppCache(&service, 111);
+ scoped_refptr<AppCache> cache1(new AppCache(&service, 111));
cache1->set_complete(true);
cache1->set_update_time(now);
group->AddCache(cache1);
EXPECT_EQ(cache1, group->newest_complete_cache());
// Adding older cache does not change newest complete cache.
- scoped_refptr<AppCache> cache2 = new AppCache(&service, 222);
+ scoped_refptr<AppCache> cache2(new AppCache(&service, 222));
cache2->set_complete(true);
cache2->set_update_time(now - base::TimeDelta::FromDays(1));
group->AddCache(cache2);
EXPECT_EQ(cache1, group->newest_complete_cache());
// Adding newer cache does change newest complete cache.
- scoped_refptr<AppCache> cache3 = new AppCache(&service, 333);
+ scoped_refptr<AppCache> cache3(new AppCache(&service, 333));
cache3->set_complete(true);
cache3->set_update_time(now + base::TimeDelta::FromDays(1));
group->AddCache(cache3);
EXPECT_EQ(cache3, group->newest_complete_cache());
// Adding cache with same update time uses one with larger ID.
- scoped_refptr<AppCache> cache4 = new AppCache(&service, 444);
+ scoped_refptr<AppCache> cache4(new AppCache(&service, 444));
cache4->set_complete(true);
cache4->set_update_time(now + base::TimeDelta::FromDays(1)); // same as 3
group->AddCache(cache4);
EXPECT_EQ(cache4, group->newest_complete_cache());
- scoped_refptr<AppCache> cache5 = new AppCache(&service, 55); // smaller id
+ scoped_refptr<AppCache> cache5(new AppCache(&service, 55)); // smaller id
cache5->set_complete(true);
cache5->set_update_time(now + base::TimeDelta::FromDays(1)); // same as 4
group->AddCache(cache5);
@@ -209,8 +209,8 @@ TEST(AppCacheGroupTest, CleanupUnusedGroup) {
TEST(AppCacheGroupTest, StartUpdate) {
MockAppCacheService service;
- scoped_refptr<AppCacheGroup> group =
- new AppCacheGroup(&service, GURL("http://foo.com"), 111);
+ scoped_refptr<AppCacheGroup> group(
+ new AppCacheGroup(&service, GURL("http://foo.com"), 111));
// Set state to checking to prevent update job from executing fetches.
group->update_status_ = AppCacheGroup::CHECKING;
@@ -230,8 +230,8 @@ TEST(AppCacheGroupTest, StartUpdate) {
TEST(AppCacheGroupTest, CancelUpdate) {
MockAppCacheService service;
- scoped_refptr<AppCacheGroup> group =
- new AppCacheGroup(&service, GURL("http://foo.com"), 111);
+ scoped_refptr<AppCacheGroup> group(
+ new AppCacheGroup(&service, GURL("http://foo.com"), 111));
// Set state to checking to prevent update job from executing fetches.
group->update_status_ = AppCacheGroup::CHECKING;
@@ -249,8 +249,8 @@ TEST(AppCacheGroupTest, CancelUpdate) {
TEST(AppCacheGroupTest, QueueUpdate) {
MockAppCacheService service;
- scoped_refptr<AppCacheGroup> group =
- new AppCacheGroup(&service, GURL("http://foo.com"), 111);
+ scoped_refptr<AppCacheGroup> group(
+ new AppCacheGroup(&service, GURL("http://foo.com"), 111));
// Set state to checking to prevent update job from executing fetches.
group->update_status_ = AppCacheGroup::CHECKING;
« no previous file with comments | « remoting/protocol/util.cc ('k') | webkit/appcache/appcache_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698