Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: remoting/jingle_glue/channel_socket_adapter_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/simple_host_process.cc ('k') | remoting/jingle_glue/ssl_socket_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/jingle_glue/channel_socket_adapter_unittest.cc
diff --git a/remoting/jingle_glue/channel_socket_adapter_unittest.cc b/remoting/jingle_glue/channel_socket_adapter_unittest.cc
index ac2c591e5d19304cac1ffefab8ea8d539e9b612e..867332f60db182843ce4d86a1c82f9f03646a4a9 100644
--- a/remoting/jingle_glue/channel_socket_adapter_unittest.cc
+++ b/remoting/jingle_glue/channel_socket_adapter_unittest.cc
@@ -64,7 +64,7 @@ class TransportChannelSocketAdapterTest : public testing::Test {
// Verify that Read() returns net::ERR_IO_PENDING.
TEST_F(TransportChannelSocketAdapterTest, Read) {
- scoped_refptr<IOBuffer> buffer = new IOBuffer(kBufferSize);
+ scoped_refptr<IOBuffer> buffer(new IOBuffer(kBufferSize));
int result = target_->Read(buffer, kBufferSize, &callback_);
ASSERT_EQ(net::ERR_IO_PENDING, result);
@@ -75,7 +75,7 @@ TEST_F(TransportChannelSocketAdapterTest, Read) {
// Verify that Read() after Close() returns error.
TEST_F(TransportChannelSocketAdapterTest, ReadClose) {
- scoped_refptr<IOBuffer> buffer = new IOBuffer(kBufferSize);
+ scoped_refptr<IOBuffer> buffer(new IOBuffer(kBufferSize));
int result = target_->Read(buffer, kBufferSize, &callback_);
ASSERT_EQ(net::ERR_IO_PENDING, result);
@@ -89,7 +89,7 @@ TEST_F(TransportChannelSocketAdapterTest, ReadClose) {
// Verify that Write sends the packet and returns correct result.
TEST_F(TransportChannelSocketAdapterTest, Write) {
- scoped_refptr<IOBuffer> buffer = new IOBuffer(kTestDataSize);
+ scoped_refptr<IOBuffer> buffer(new IOBuffer(kTestDataSize));
EXPECT_CALL(channel_, SendPacket(buffer->data(), kTestDataSize))
.WillOnce(Return(kTestDataSize));
@@ -101,7 +101,7 @@ TEST_F(TransportChannelSocketAdapterTest, Write) {
// Verify that the message is still send if Write() is called while
// socket is not open yet, and that the callback is called.
TEST_F(TransportChannelSocketAdapterTest, WritePending) {
- scoped_refptr<IOBuffer> buffer = new IOBuffer(kTestDataSize);
+ scoped_refptr<IOBuffer> buffer(new IOBuffer(kTestDataSize));
EXPECT_CALL(channel_, SendPacket(buffer->data(), kTestDataSize))
.Times(2)
« no previous file with comments | « remoting/host/simple_host_process.cc ('k') | remoting/jingle_glue/ssl_socket_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698