net/socket/client_socket_pool_base_unittest.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_base_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/client_socket_pool_base_unittest.cc

diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc

index f8d2d1feae5fa683b2316f97c0ab620c6b0ecd07..7cf35e3cff45b99c6768448ec605c8ed3909818e 100644

--- a/net/socket/client_socket_pool_base_unittest.cc

+++ b/net/socket/client_socket_pool_base_unittest.cc

@@ -1281,7 +1281,7 @@ class RequestSocketCallback : public CallbackRunner< Tuple1<int> > {

}

within_callback_ = true;

TestCompletionCallback next_job_callback;

- scoped_refptr<TestSocketParams> params = new TestSocketParams();

+ scoped_refptr<TestSocketParams> params(new TestSocketParams());

int rv = handle_->Init("a",

params,

kDefaultPriority,

@@ -2087,7 +2087,7 @@ class TestReleasingSocketRequest : public CallbackRunner< Tuple1<int> > {

callback_.RunWithParams(params);

if (reset_releasing_handle_)

handle_.Reset();

- scoped_refptr<TestSocketParams> con_params = new TestSocketParams();

+ scoped_refptr<TestSocketParams> con_params(new TestSocketParams());

EXPECT_EQ(expected_result_, handle2_.Init("a",

con_params,

kDefaultPriority,

« no previous file with comments | « net/server/http_listen_socket.cc ('k') | net/socket/deterministic_socket_data_unittest.cc » ('j') | no next file with comments »