net/proxy/multi_threaded_proxy_resolver.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/multi_threaded_proxy_resolver.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/multi_threaded_proxy_resolver.cc

diff --git a/net/proxy/multi_threaded_proxy_resolver.cc b/net/proxy/multi_threaded_proxy_resolver.cc

index 95071b1688b9eef9a21395fcfcb9ffe78106ddb0..22fe5e4241925c8786e204f7c363108bf258ae37 100644

--- a/net/proxy/multi_threaded_proxy_resolver.cc

+++ b/net/proxy/multi_threaded_proxy_resolver.cc

@@ -410,8 +410,8 @@ int MultiThreadedProxyResolver::GetProxyForURL(const GURL& url,

DCHECK(current_script_data_.get())

<< "Resolver is un-initialized. Must call SetPacScript() first!";

- scoped_refptr<GetProxyForURLJob> job =

- new GetProxyForURLJob(url, results, callback, net_log);

+ scoped_refptr<GetProxyForURLJob> job(

+ new GetProxyForURLJob(url, results, callback, net_log));

// Completion will be notified through |callback|, unless the caller cancels

// the request using |request|.

« no previous file with comments | « net/http/http_transaction_unittest.cc ('k') | net/proxy/proxy_script_fetcher_impl_unittest.cc » ('j') | no next file with comments »