Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: media/base/data_buffer_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_output_controller.cc ('k') | media/base/pipeline_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/data_buffer_unittest.cc
diff --git a/media/base/data_buffer_unittest.cc b/media/base/data_buffer_unittest.cc
index 2d014ffaf6fcf8a3691acba1cc9b09920dd8254b..8e40d1a60702199294d40c7773a1cb16c0600c88 100644
--- a/media/base/data_buffer_unittest.cc
+++ b/media/base/data_buffer_unittest.cc
@@ -15,7 +15,7 @@ TEST(DataBufferTest, StreamSampleImpl) {
const base::TimeDelta kDurationB = base::TimeDelta::FromMicroseconds(5678);
// Create a DataBuffer.
- scoped_refptr<DataBuffer> buffer = new DataBuffer(0);
+ scoped_refptr<DataBuffer> buffer(new DataBuffer(0));
ASSERT_TRUE(buffer);
buffer->SetTimestamp(kTimestampA);
@@ -38,10 +38,10 @@ TEST(DataBufferTest, StreamSampleImpl) {
TEST(DataBufferTest, Ctors) {
const size_t kTestSize = 10;
- scoped_refptr<DataBuffer> buffer = new DataBuffer(0);
+ scoped_refptr<DataBuffer> buffer(new DataBuffer(0));
EXPECT_FALSE(buffer->GetData());
- scoped_refptr<DataBuffer> buffer2 = new DataBuffer(kTestSize);
+ scoped_refptr<DataBuffer> buffer2(new DataBuffer(kTestSize));
EXPECT_EQ(0u, buffer2->GetDataSize());
EXPECT_EQ(kTestSize, buffer2->GetBufferSize());
}
@@ -53,7 +53,7 @@ TEST(DataBufferTest, WritableBufferImpl) {
const size_t kNewDataSize = arraysize(kNewData);
// Create a DataBuffer.
- scoped_refptr<DataBuffer> buffer = new DataBuffer(kDataSize);
+ scoped_refptr<DataBuffer> buffer(new DataBuffer(kDataSize));
ASSERT_TRUE(buffer);
uint8* data = buffer->GetWritableData();
@@ -66,7 +66,7 @@ TEST(DataBufferTest, WritableBufferImpl) {
ASSERT_EQ(0, memcmp(read_only_data, kData, kDataSize));
EXPECT_FALSE(buffer->IsEndOfStream());
- scoped_refptr<DataBuffer> buffer2 = new DataBuffer(kNewDataSize + 10);
+ scoped_refptr<DataBuffer> buffer2(new DataBuffer(kNewDataSize + 10));
data = buffer2->GetWritableData();
ASSERT_TRUE(data);
ASSERT_EQ(kNewDataSize + 10, buffer2->GetBufferSize());
« no previous file with comments | « media/audio/audio_output_controller.cc ('k') | media/base/pipeline_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698