chrome/browser/themes/browser_theme_pack.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/browser_theme_pack.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_typed_url_unittest.cc ('k') | chrome/browser/themes/browser_theme_pack_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/browser_theme_pack.cc

diff --git a/chrome/browser/themes/browser_theme_pack.cc b/chrome/browser/themes/browser_theme_pack.cc

index 56cbdbf0c2a58a965ee71768b99e188c440e1ceb..c0b00816c61a64f4dccb74b4493f243f9bd31fad 100644

--- a/chrome/browser/themes/browser_theme_pack.cc

+++ b/chrome/browser/themes/browser_theme_pack.cc

@@ -368,7 +368,7 @@ BrowserThemePack* BrowserThemePack::BuildFromExtension(

scoped_refptr<BrowserThemePack> BrowserThemePack::BuildFromDataPack(

FilePath path, const std::string& expected_id) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

- scoped_refptr<BrowserThemePack> pack = new BrowserThemePack;

+ scoped_refptr<BrowserThemePack> pack(new BrowserThemePack);

pack->data_pack_.reset(new base::DataPack);

if (!pack->data_pack_->Load(path)) {