chrome/browser/ssl/ssl_manager.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_manager.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/ssl_host_state_unittest.cc ('k') | chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_manager.cc

diff --git a/chrome/browser/ssl/ssl_manager.cc b/chrome/browser/ssl/ssl_manager.cc

index c894a44ff92fd779df8cf1c45643fe08fbe02f8d..208a9d29ef14048d0bc50c1909a1988c0bec3131 100644

--- a/chrome/browser/ssl/ssl_manager.cc

+++ b/chrome/browser/ssl/ssl_manager.cc

@@ -210,14 +210,14 @@ void SSLManager::DidLoadFromMemoryCache(LoadFromMemoryCacheDetails* details) {

// caches sub-resources.

// This resource must have been loaded with no filtering because filtered

// resouces aren't cachable.

- scoped_refptr<SSLRequestInfo> info = new SSLRequestInfo(

+ scoped_refptr<SSLRequestInfo> info(new SSLRequestInfo(

details->url(),

ResourceType::SUB_RESOURCE,

details->frame_origin(),

details->main_frame_origin(),

details->pid(),

details->ssl_cert_id(),

- details->ssl_cert_status());

+ details->ssl_cert_status()));

// Simulate loading this resource through the usual path.

policy()->OnRequestStarted(info.get());

@@ -226,14 +226,14 @@ void SSLManager::DidLoadFromMemoryCache(LoadFromMemoryCacheDetails* details) {

void SSLManager::DidStartResourceResponse(ResourceRequestDetails* details) {

DCHECK(details);

- scoped_refptr<SSLRequestInfo> info = new SSLRequestInfo(

+ scoped_refptr<SSLRequestInfo> info(new SSLRequestInfo(

details->url(),

details->resource_type(),

details->frame_origin(),

details->main_frame_origin(),

details->origin_child_id(),

details->ssl_cert_id(),

- details->ssl_cert_status());

+ details->ssl_cert_status()));

// Notify our policy that we started a resource request. Ideally, the

// policy should have the ability to cancel the request, but we can't do