Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3281)

Unified Diff: chrome/browser/safe_browsing/bloom_filter_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/bloom_filter_unittest.cc
diff --git a/chrome/browser/safe_browsing/bloom_filter_unittest.cc b/chrome/browser/safe_browsing/bloom_filter_unittest.cc
index 1268e0219852c4f29feb2a4aa3fb11644f4fb28b..97c1558bfe656f54df54b0256d93200c41d8a4f0 100644
--- a/chrome/browser/safe_browsing/bloom_filter_unittest.cc
+++ b/chrome/browser/safe_browsing/bloom_filter_unittest.cc
@@ -30,8 +30,8 @@ TEST(SafeBrowsingBloomFilter, BloomFilterUse) {
int count = 1000;
// Build up the bloom filter.
- scoped_refptr<BloomFilter> filter =
- new BloomFilter(count * BloomFilter::kBloomFilterSizeRatio);
+ scoped_refptr<BloomFilter> filter(
+ new BloomFilter(count * BloomFilter::kBloomFilterSizeRatio));
typedef std::set<SBPrefix> Values;
Values values;
@@ -44,8 +44,8 @@ TEST(SafeBrowsingBloomFilter, BloomFilterUse) {
// Check serialization works.
char* data_copy = new char[filter->size()];
memcpy(data_copy, filter->data(), filter->size());
- scoped_refptr<BloomFilter> filter_copy =
- new BloomFilter(data_copy, filter->size(), filter->hash_keys_);
+ scoped_refptr<BloomFilter> filter_copy(
+ new BloomFilter(data_copy, filter->size(), filter->hash_keys_));
// Check no false negatives by ensuring that every time we inserted exists.
for (Values::const_iterator i = values.begin(); i != values.end(); ++i)
@@ -82,8 +82,8 @@ TEST(SafeBrowsingBloomFilter, BloomFilterUse) {
TEST(SafeBrowsingBloomFilter, BloomFilterFile) {
// Create initial filter.
const int kTestEntries = BloomFilter::kBloomFilterMinSize;
- scoped_refptr<BloomFilter> filter_write =
- new BloomFilter(kTestEntries * BloomFilter::kBloomFilterSizeRatio);
+ scoped_refptr<BloomFilter> filter_write(
+ new BloomFilter(kTestEntries * BloomFilter::kBloomFilterSizeRatio));
for (int i = 0; i < kTestEntries; ++i)
filter_write->Insert(GenHash());
@@ -99,7 +99,7 @@ TEST(SafeBrowsingBloomFilter, BloomFilterFile) {
// Create new empty filter and load from disk.
BloomFilter* filter = BloomFilter::LoadFile(filter_path);
ASSERT_TRUE(filter != NULL);
- scoped_refptr<BloomFilter> filter_read = filter;
+ scoped_refptr<BloomFilter> filter_read(filter);
// Check data consistency.
EXPECT_EQ(filter_write->hash_keys_.size(), filter_read->hash_keys_.size());
« no previous file with comments | « chrome/browser/renderer_host/x509_user_cert_resource_handler.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698