chrome/browser/importer/importer_unittest.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/importer_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/importer/firefox_importer_unittest_utils_mac.cc ('k') | chrome/browser/in_process_webkit/browser_webkitclient_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/importer/importer_unittest.cc

diff --git a/chrome/browser/importer/importer_unittest.cc b/chrome/browser/importer/importer_unittest.cc

index 2bad8eeaccbc6c0bc6c803c50d903c4c3d60d5c5..5261c03331484f4f833244c6969732c49b8dace9 100644

--- a/chrome/browser/importer/importer_unittest.cc

+++ b/chrome/browser/importer/importer_unittest.cc

@@ -115,7 +115,7 @@ class ImporterTest : public testing::Test {

profile_info.browser_type = FIREFOX3;

profile_info.app_path = app_path_;

profile_info.source_path = profile_path_;

- scoped_refptr<ImporterHost> host = new ImporterHost();

+ scoped_refptr<ImporterHost> host(new ImporterHost());

host->SetObserver(observer);

int items = HISTORY | PASSWORDS | FAVORITES;

if (import_search_plugins)

@@ -697,7 +697,7 @@ TEST_F(ImporterTest, MAYBE(Firefox2Importer)) {

ASSERT_TRUE(file_util::CopyDirectory(data_path, search_engine_path, false));

MessageLoop* loop = MessageLoop::current();

- scoped_refptr<ImporterHost> host = new ImporterHost();

+ scoped_refptr<ImporterHost> host(new ImporterHost());

FirefoxObserver* observer = new FirefoxObserver();

host->SetObserver(observer);

ProfileInfo profile_info;

@@ -880,15 +880,15 @@ class Firefox3Observer : public ProfileWriter,

};

TEST_F(ImporterTest, MAYBE(Firefox30Importer)) {

- scoped_refptr<Firefox3Observer> observer = new Firefox3Observer();

+ scoped_refptr<Firefox3Observer> observer(new Firefox3Observer());

Firefox3xImporterTest("firefox3_profile", observer.get(), observer.get(),

true);

}

TEST_F(ImporterTest, MAYBE(Firefox35Importer)) {

bool import_search_engines = false;

- scoped_refptr<Firefox3Observer> observer =

- new Firefox3Observer(import_search_engines);

+ scoped_refptr<Firefox3Observer> observer(

+ new Firefox3Observer(import_search_engines));

Firefox3xImporterTest("firefox35_profile", observer.get(), observer.get(),

import_search_engines);

}