chrome/browser/extensions/extension_updater.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_updater.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/extensions/extension_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_updater.cc

diff --git a/chrome/browser/extensions/extension_updater.cc b/chrome/browser/extensions/extension_updater.cc

index df194897a8497989ac0e475365425844f96c565f..3c678e57cd09b0114e7630bca980d3e54d96e919 100644

--- a/chrome/browser/extensions/extension_updater.cc

+++ b/chrome/browser/extensions/extension_updater.cc

@@ -518,8 +518,8 @@ void ExtensionUpdater::OnManifestFetchComplete(const GURL& url,

// We want to try parsing the manifest, and if it indicates updates are

// available, we want to fire off requests to fetch those updates.

if (status.status() == URLRequestStatus::SUCCESS && response_code == 200) {

- scoped_refptr<SafeManifestParser> safe_parser =

- new SafeManifestParser(data, current_manifest_fetch_.release(), this);

+ scoped_refptr<SafeManifestParser> safe_parser(

+ new SafeManifestParser(data, current_manifest_fetch_.release(), this));

safe_parser->Start();

} else {

// TODO(asargent) Do exponential backoff here. (http://crbug.com/12546).

« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/extensions/extension_updater_unittest.cc » ('j') | no next file with comments »