chrome/browser/browsing_data_database_helper_unittest.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data_database_helper_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data_appcache_helper_unittest.cc ('k') | chrome/browser/browsing_data_local_storage_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data_database_helper_unittest.cc

diff --git a/chrome/browser/browsing_data_database_helper_unittest.cc b/chrome/browser/browsing_data_database_helper_unittest.cc

index c8f1c1863155bf83b2d7fcdb08f116c337a5258d..ca23f39a2cfac68e710bfadb33f457106374f9fd 100644

--- a/chrome/browser/browsing_data_database_helper_unittest.cc

+++ b/chrome/browser/browsing_data_database_helper_unittest.cc

@@ -46,8 +46,8 @@ TEST(CannedBrowsingDataDatabaseTest, AddDatabase) {

const char db2[] = "db2";

const char db3[] = "db3";

- scoped_refptr<CannedBrowsingDataDatabaseHelper> helper =

- new CannedBrowsingDataDatabaseHelper(&profile);

+ scoped_refptr<CannedBrowsingDataDatabaseHelper> helper(

+ new CannedBrowsingDataDatabaseHelper(&profile));

helper->AddDatabase(origin1, db1, "");

helper->AddDatabase(origin1, db2, "");

helper->AddDatabase(origin2, db3, "");

@@ -76,8 +76,8 @@ TEST(CannedBrowsingDataDatabaseTest, Unique) {

const char origin_str[] = "http_host1_1";

const char db[] = "db1";

- scoped_refptr<CannedBrowsingDataDatabaseHelper> helper =

- new CannedBrowsingDataDatabaseHelper(&profile);

+ scoped_refptr<CannedBrowsingDataDatabaseHelper> helper(

+ new CannedBrowsingDataDatabaseHelper(&profile));

helper->AddDatabase(origin, db, "");

@@ -100,8 +100,8 @@ TEST(CannedBrowsingDataDatabaseTest, Empty) {

const GURL origin("http://host1:1/");

const char db[] = "db1";

- scoped_refptr<CannedBrowsingDataDatabaseHelper> helper =

- new CannedBrowsingDataDatabaseHelper(&profile);

+ scoped_refptr<CannedBrowsingDataDatabaseHelper> helper(

+ new CannedBrowsingDataDatabaseHelper(&profile));

ASSERT_TRUE(helper->empty());

helper->AddDatabase(origin, db, "");