chrome/browser/bookmarks/bookmark_html_writer.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_html_writer.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/bookmarks/bookmark_html_writer.cc

diff --git a/chrome/browser/bookmarks/bookmark_html_writer.cc b/chrome/browser/bookmarks/bookmark_html_writer.cc

index d66c35ff2f8ffbe73272daeb0abb4513f184a120..38899bf0b5929f856759d203925f2991bdcb58d0 100644

--- a/chrome/browser/bookmarks/bookmark_html_writer.cc

+++ b/chrome/browser/bookmarks/bookmark_html_writer.cc

@@ -249,7 +249,7 @@ class Writer : public Task {

BookmarkFaviconFetcher::URLFaviconMap::iterator itr =

favicons_map_->find(url_string);

if (itr != favicons_map_->end()) {

- scoped_refptr<RefCountedMemory> data = itr->second.get();

+ scoped_refptr<RefCountedMemory> data(itr->second.get());

std::string favicon_data;

favicon_data.assign(reinterpret_cast<const char*>(data->front()),

data->size());

« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/browser_about_handler.cc » ('j') | no next file with comments »