base/ref_counted_unittest.cc - Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/ref_counted_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: fix presubmit Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/ref_counted_unittest.cc

diff --git a/base/ref_counted_unittest.cc b/base/ref_counted_unittest.cc

index f2739fcea6e6380ffdf2f79f53514eb0cb547885..cd6f922414a75644dd7e9ce6fcf37aee4f60cf55 100644

--- a/base/ref_counted_unittest.cc

+++ b/base/ref_counted_unittest.cc

@@ -26,7 +26,7 @@ class CheckDerivedMemberAccess : public scoped_refptr<SelfAssign> {

TEST(RefCountedUnitTest, TestSelfAssignment) {

SelfAssign* p = new SelfAssign;

- scoped_refptr<SelfAssign> var = p;

+ scoped_refptr<SelfAssign> var(p);

var = var;

EXPECT_EQ(var.get(), p);

}

« no previous file with comments | « base/metrics/field_trial_unittest.cc ('k') | chrome/browser/automation/automation_resource_message_filter.cc » ('j') | no next file with comments »