Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: webkit/appcache/appcache_storage_unittest.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/appcache/appcache_storage_impl_unittest.cc ('k') | webkit/appcache/appcache_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop.h" 5 #include "base/message_loop.h"
6 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
7 #include "webkit/appcache/appcache.h" 7 #include "webkit/appcache/appcache.h"
8 #include "webkit/appcache/appcache_group.h" 8 #include "webkit/appcache/appcache_group.h"
9 #include "webkit/appcache/appcache_response.h" 9 #include "webkit/appcache/appcache_response.h"
10 #include "webkit/appcache/appcache_storage.h" 10 #include "webkit/appcache/appcache_storage.h"
11 #include "webkit/appcache/mock_appcache_service.h" 11 #include "webkit/appcache/mock_appcache_service.h"
12 12
13 namespace appcache { 13 namespace appcache {
14 14
15 class AppCacheStorageTest : public testing::Test { 15 class AppCacheStorageTest : public testing::Test {
16 public: 16 public:
17 class MockStorageDelegate : public AppCacheStorage::Delegate { 17 class MockStorageDelegate : public AppCacheStorage::Delegate {
18 public: 18 public:
19 }; 19 };
20 }; 20 };
21 21
22 TEST_F(AppCacheStorageTest, AddRemoveCache) { 22 TEST_F(AppCacheStorageTest, AddRemoveCache) {
23 MockAppCacheService service; 23 MockAppCacheService service;
24 scoped_refptr<AppCache> cache = new AppCache(&service, 111); 24 scoped_refptr<AppCache> cache(new AppCache(&service, 111));
25 25
26 EXPECT_EQ(cache.get(), 26 EXPECT_EQ(cache.get(),
27 service.storage()->working_set()->GetCache(111)); 27 service.storage()->working_set()->GetCache(111));
28 28
29 service.storage()->working_set()->RemoveCache(cache); 29 service.storage()->working_set()->RemoveCache(cache);
30 30
31 EXPECT_TRUE(!service.storage()->working_set()->GetCache(111)); 31 EXPECT_TRUE(!service.storage()->working_set()->GetCache(111));
32 32
33 // Removing non-existing cache from service should not fail. 33 // Removing non-existing cache from service should not fail.
34 MockAppCacheService dummy; 34 MockAppCacheService dummy;
35 dummy.storage()->working_set()->RemoveCache(cache); 35 dummy.storage()->working_set()->RemoveCache(cache);
36 } 36 }
37 37
38 TEST_F(AppCacheStorageTest, AddRemoveGroup) { 38 TEST_F(AppCacheStorageTest, AddRemoveGroup) {
39 MockAppCacheService service; 39 MockAppCacheService service;
40 scoped_refptr<AppCacheGroup> group = new AppCacheGroup(&service, GURL(), 111); 40 scoped_refptr<AppCacheGroup> group(new AppCacheGroup(&service, GURL(), 111));
41 41
42 EXPECT_EQ(group.get(), service.storage()->working_set()->GetGroup(GURL())); 42 EXPECT_EQ(group.get(), service.storage()->working_set()->GetGroup(GURL()));
43 43
44 service.storage()->working_set()->RemoveGroup(group); 44 service.storage()->working_set()->RemoveGroup(group);
45 45
46 EXPECT_TRUE(!service.storage()->working_set()->GetGroup(GURL())); 46 EXPECT_TRUE(!service.storage()->working_set()->GetGroup(GURL()));
47 47
48 // Removing non-existing group from service should not fail. 48 // Removing non-existing group from service should not fail.
49 MockAppCacheService dummy; 49 MockAppCacheService dummy;
50 dummy.storage()->working_set()->RemoveGroup(group); 50 dummy.storage()->working_set()->RemoveGroup(group);
51 } 51 }
52 52
53 TEST_F(AppCacheStorageTest, AddRemoveResponseInfo) { 53 TEST_F(AppCacheStorageTest, AddRemoveResponseInfo) {
54 MockAppCacheService service; 54 MockAppCacheService service;
55 scoped_refptr<AppCacheResponseInfo> info = 55 scoped_refptr<AppCacheResponseInfo> info(
56 new AppCacheResponseInfo(&service, GURL(), 56 new AppCacheResponseInfo(&service, GURL(),
57 111, new net::HttpResponseInfo, 57 111, new net::HttpResponseInfo,
58 kUnkownResponseDataSize); 58 kUnkownResponseDataSize));
59 59
60 EXPECT_EQ(info.get(), 60 EXPECT_EQ(info.get(),
61 service.storage()->working_set()->GetResponseInfo(111)); 61 service.storage()->working_set()->GetResponseInfo(111));
62 62
63 service.storage()->working_set()->RemoveResponseInfo(info); 63 service.storage()->working_set()->RemoveResponseInfo(info);
64 64
65 EXPECT_TRUE(!service.storage()->working_set()->GetResponseInfo(111)); 65 EXPECT_TRUE(!service.storage()->working_set()->GetResponseInfo(111));
66 66
67 // Removing non-existing info from service should not fail. 67 // Removing non-existing info from service should not fail.
68 MockAppCacheService dummy; 68 MockAppCacheService dummy;
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 delegate_reference2 = 102 delegate_reference2 =
103 service.storage()->GetOrCreateDelegateReference(&delegate); 103 service.storage()->GetOrCreateDelegateReference(&delegate);
104 EXPECT_TRUE(delegate_reference2.get()); 104 EXPECT_TRUE(delegate_reference2.get());
105 EXPECT_TRUE(delegate_reference2->HasOneRef()); 105 EXPECT_TRUE(delegate_reference2->HasOneRef());
106 EXPECT_EQ(&delegate, delegate_reference2->delegate); 106 EXPECT_EQ(&delegate, delegate_reference2->delegate);
107 EXPECT_NE(delegate_reference1.get(), delegate_reference2.get()); 107 EXPECT_NE(delegate_reference1.get(), delegate_reference2.get());
108 } 108 }
109 109
110 } // namespace appcache 110 } // namespace appcache
OLDNEW
« no previous file with comments | « webkit/appcache/appcache_storage_impl_unittest.cc ('k') | webkit/appcache/appcache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698