Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: net/disk_cache/backend_impl.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/base/x509_certificate_unittest.cc ('k') | net/disk_cache/backend_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/disk_cache/backend_impl.h" 5 #include "net/disk_cache/backend_impl.h"
6 6
7 #include "base/file_path.h" 7 #include "base/file_path.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 // Initializes the field trial structures to allow performance measurements 167 // Initializes the field trial structures to allow performance measurements
168 // for the current cache configuration. Returns true if we are active part of 168 // for the current cache configuration. Returns true if we are active part of
169 // the CacheThrottle field trial. 169 // the CacheThrottle field trial.
170 bool SetFieldTrialInfo(int size_group) { 170 bool SetFieldTrialInfo(int size_group) {
171 static bool first = true; 171 static bool first = true;
172 if (!first) 172 if (!first)
173 return false; 173 return false;
174 174
175 // Field trials involve static objects so we have to do this only once. 175 // Field trials involve static objects so we have to do this only once.
176 first = false; 176 first = false;
177 scoped_refptr<base::FieldTrial> trial1 = 177 scoped_refptr<base::FieldTrial> trial1(
178 new base::FieldTrial("CacheSize", 10); 178 new base::FieldTrial("CacheSize", 10));
179 std::string group1 = base::StringPrintf("CacheSizeGroup_%d", size_group); 179 std::string group1 = base::StringPrintf("CacheSizeGroup_%d", size_group);
180 trial1->AppendGroup(group1, base::FieldTrial::kAllRemainingProbability); 180 trial1->AppendGroup(group1, base::FieldTrial::kAllRemainingProbability);
181 181
182 scoped_refptr<base::FieldTrial> trial2 = 182 scoped_refptr<base::FieldTrial> trial2(
183 new base::FieldTrial("CacheThrottle", 100); 183 new base::FieldTrial("CacheThrottle", 100));
184 int group2a = trial2->AppendGroup("CacheThrottle_On", 10); // 10 % in. 184 int group2a = trial2->AppendGroup("CacheThrottle_On", 10); // 10 % in.
185 trial2->AppendGroup("CacheThrottle_Off", 10); // 10 % control. 185 trial2->AppendGroup("CacheThrottle_Off", 10); // 10 % control.
186 186
187 return trial2->group() == group2a; 187 return trial2->group() == group2a;
188 } 188 }
189 189
190 // ------------------------------------------------------------------------ 190 // ------------------------------------------------------------------------
191 191
192 // This class takes care of building an instance of the backend. 192 // This class takes care of building an instance of the backend.
193 class CacheCreator { 193 class CacheCreator {
(...skipping 1866 matching lines...) Expand 10 before | Expand all | Expand 10 after
2060 if (total_memory > kMaxBuffersSize || total_memory <= 0) 2060 if (total_memory > kMaxBuffersSize || total_memory <= 0)
2061 total_memory = kMaxBuffersSize; 2061 total_memory = kMaxBuffersSize;
2062 2062
2063 done = true; 2063 done = true;
2064 } 2064 }
2065 2065
2066 return static_cast<int>(total_memory); 2066 return static_cast<int>(total_memory);
2067 } 2067 }
2068 2068
2069 } // namespace disk_cache 2069 } // namespace disk_cache
OLDNEW
« no previous file with comments | « net/base/x509_certificate_unittest.cc ('k') | net/disk_cache/backend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698