Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/renderer_host/x509_user_cert_resource_handler.cc

Issue 4192012: Convert implicit scoped_refptr constructor calls to explicit ones, part 1 (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: fix presubmit Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/x509_user_cert_resource_handler.h" 5 #include "chrome/browser/renderer_host/x509_user_cert_resource_handler.h"
6 6
7 #include "base/string_util.h" 7 #include "base/string_util.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/browser_thread.h" 9 #include "chrome/browser/browser_thread.h"
10 #include "chrome/browser/download/download_types.h" 10 #include "chrome/browser/download/download_types.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 bool X509UserCertResourceHandler::OnResponseCompleted( 96 bool X509UserCertResourceHandler::OnResponseCompleted(
97 int request_id, 97 int request_id,
98 const URLRequestStatus& urs, 98 const URLRequestStatus& urs,
99 const std::string& sec_info) { 99 const std::string& sec_info) {
100 if (urs.status() != URLRequestStatus::SUCCESS) 100 if (urs.status() != URLRequestStatus::SUCCESS)
101 return false; 101 return false;
102 102
103 // TODO(gauravsh): Verify that 'request_id' was actually a keygen form post 103 // TODO(gauravsh): Verify that 'request_id' was actually a keygen form post
104 // and only then import the certificate. 104 // and only then import the certificate.
105 AssembleResource(); 105 AssembleResource();
106 scoped_refptr<net::X509Certificate> cert = 106 scoped_refptr<net::X509Certificate> cert(
107 net::X509Certificate::CreateFromBytes(resource_buffer_->data(), 107 net::X509Certificate::CreateFromBytes(resource_buffer_->data(),
108 content_length_); 108 content_length_));
109 // The handler will run the UI and delete itself when it's finished. 109 // The handler will run the UI and delete itself when it's finished.
110 new SSLAddCertHandler(request_, cert, render_process_host_id_, 110 new SSLAddCertHandler(request_, cert, render_process_host_id_,
111 render_view_id_); 111 render_view_id_);
112 return true; 112 return true;
113 } 113 }
114 114
115 void X509UserCertResourceHandler::OnRequestClosed() { 115 void X509UserCertResourceHandler::OnRequestClosed() {
116 } 116 }
117 117
118 X509UserCertResourceHandler::~X509UserCertResourceHandler() { 118 X509UserCertResourceHandler::~X509UserCertResourceHandler() {
119 } 119 }
120 120
121 void X509UserCertResourceHandler::AssembleResource() { 121 void X509UserCertResourceHandler::AssembleResource() {
122 size_t bytes_copied = 0; 122 size_t bytes_copied = 0;
123 resource_buffer_ = new net::IOBuffer(content_length_); 123 resource_buffer_ = new net::IOBuffer(content_length_);
124 124
125 for (size_t i = 0; i < buffer_->contents.size(); ++i) { 125 for (size_t i = 0; i < buffer_->contents.size(); ++i) {
126 net::IOBuffer* data = buffer_->contents[i].first; 126 net::IOBuffer* data = buffer_->contents[i].first;
127 const int data_len = buffer_->contents[i].second; 127 const int data_len = buffer_->contents[i].second;
128 DCHECK(bytes_copied + data_len <= content_length_); 128 DCHECK(bytes_copied + data_len <= content_length_);
129 memcpy(resource_buffer_->data() + bytes_copied, data->data(), data_len); 129 memcpy(resource_buffer_->data() + bytes_copied, data->data(), data_len);
130 bytes_copied += data_len; 130 bytes_copied += data_len;
131 } 131 }
132 } 132 }
OLDNEW
« no previous file with comments | « chrome/browser/renderer_host/resource_message_filter.cc ('k') | chrome/browser/safe_browsing/bloom_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698