Issue 4190009: AU: Watch for writes on write fds only, and for reads on read fds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4190009: AU: Watch for writes on write fds only, and for reads on read fds. (Closed)

Created:
10 years, 1 month ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr, jrbarnette

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Watch for writes on write fds only, and for reads on read fds. This reduces the CPU load from 100% to 0% when staying idle waiting for a server response. BUG=8200 TEST=unit tests, tested on device Change-Id: I07216076753b4b0dea9672470f1a6d572482f9a2 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=60e1415

Patch Set 1 #

Patch Set 2 : fix comment #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -45 lines)			Patch
	M	libcurl_http_fetcher.h	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
	M	libcurl_http_fetcher.cc	View		2 chunks	+60 lines, -42 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

thanks for catching this!

Expand Messages | Collapse Messages