Issue 4187010: Remove a DCHECK that broke a number of text input types...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4187010: Remove a DCHECK that broke a number of text input types... (Closed)

Created:
10 years, 1 month ago by mmenke

Modified:
9 years, 7 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, James Hawkins, dhollowa, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove DCHECK that broke quite a number of text input field types in debug builds (Including the search field on net-internals). In addition to "text" input fields, "Search", "color", "number", date/time, and who knows what other input types all use text fields. BUG=61261 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64548

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/renderer/autofill_helper.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mmenke

If you feel that DCHECK is important, feel free to figure out exacty which text ...

10 years, 1 month ago (2010-10-30 09:15:09 UTC) #1

mmenke

10 years, 1 month ago (2010-10-30 12:58:13 UTC) #3

On 2010/10/30 09:18:22, Ilya Sherman wrote:
> LGTM; apologies for the breakage

Thanks.  Not a problem.

Expand Messages | Collapse Messages